Skip to content

Commit

Permalink
address suggestions from code review
Browse files Browse the repository at this point in the history
  • Loading branch information
Henry8192 committed Oct 21, 2024
1 parent 94901f9 commit 0a4d001
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion components/log-viewer-webui/client/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion components/log-viewer-webui/client/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
"mini-css-extract-plugin": "^2.9.0",
"react-refresh": "^0.14.2",
"style-loader": "^4.0.0",
"webpack": "^5.94.0",
"webpack": "^5.95.0",
"webpack-cli": "^5.1.4",
"webpack-dev-server": "^5.1.0"
},
Expand Down
4 changes: 2 additions & 2 deletions components/log-viewer-webui/server/src/DbManager.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import fastifyPlugin from "fastify-plugin";

import fastifyMongo from "@fastify/mongodb";
import fastifyMysql from "@fastify/mysql";
import msgpack from "@msgpack/msgpack";
import {encode as msgpackEncode} from "@msgpack/msgpack";

import {sleep} from "./utils.js";

Expand Down Expand Up @@ -113,7 +113,7 @@ class DbManager {
`INSERT INTO ${this.#queryJobsTableName} (job_config, type)
VALUES (?, ?)`,
[
Buffer.from(msgpack.encode(jobConfig)),
Buffer.from(encode(jobConfig)),
QUERY_JOB_TYPE.EXTRACT_IR,
]
);
Expand Down
2 changes: 1 addition & 1 deletion requirements.txt
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
pip~=23.3
poetry~=1.7
setuptools>=70.0.0
setuptools~=75.2.0

0 comments on commit 0a4d001

Please sign in to comment.