Skip to content
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
4e5228f
changes for taskfile infra
20001020ycx May 22, 2026
20001f3
Merge branch 'main' into feat/2026-05-22-velox-connector-taskfile
20001020ycx May 25, 2026
b6fb0a3
add cmake change + nit changes on taskfiles
20001020ycx May 25, 2026
01ad866
add missing EOF for the new files
20001020ycx May 25, 2026
209850f
add missing reference in Readme and hash SHA256 update
20001020ycx May 26, 2026
4f90b68
update cmake + deps + some submodule update
20001020ycx May 28, 2026
3ea02f3
disable CLP-S archive writer
20001020ycx May 28, 2026
eca45b8
refactor: Move velox-connector taskfiles to repo root
20001020ycx Jun 8, 2026
218d465
fix: Make deps tasks public so velox-connector:deps:install-all is ca…
20001020ycx Jun 8, 2026
e80f7c0
fix: Remove old velox-connector taskfile files (restored by earlier c…
20001020ycx Jun 8, 2026
f415e17
fix dependency
20001020ycx Jun 9, 2026
bb377d1
Merge branch 'main' of github.com:y-scope/clp-plugin-presto-connector…
20001020ycx Jun 9, 2026
8908d75
adding clean task + review fixes
20001020ycx Jun 9, 2026
27867b3
nits on README format
20001020ycx Jun 9, 2026
9b4a0af
nits on cmakelist
20001020ycx Jun 9, 2026
38a4b96
Pass CMake settings file path to CMake project rather than dependenci…
kirkrodrigues Jun 15, 2026
4cca9cf
Apply suggestions from Kirk's review
20001020ycx Jun 15, 2026
ce4cc18
address Kirk's comment
20001020ycx Jun 15, 2026
998f919
address jack's comment
20001020ycx Jun 17, 2026
9422359
Apply suggestions from code review
20001020ycx Jun 18, 2026
b97bd93
code changes for addresssing Kirk's comment
20001020ycx Jun 18, 2026
42d3d21
README update
20001020ycx Jun 18, 2026
5bd5f09
Update velox-connector/README.md
20001020ycx Jun 18, 2026
da8256d
Update velox-connector/README.md
20001020ycx Jun 18, 2026
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .gitmodules
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
[submodule "velox-connector/tools/yscope-dev-utils"]
path = velox-connector/tools/yscope-dev-utils
url = https://github.com/y-scope/yscope-dev-utils.git
16 changes: 16 additions & 0 deletions velox-connector/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,22 @@ set(CMAKE_POSITION_INDEPENDENT_CODE ON)
# causing dlopen to fail with an unresolved symbol error.
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -mavx2")

# ==============================================================================
# Dependencies
# ==============================================================================

# Use the Taskfile-installed dependencies (task deps:plugin).
#
# NOTE: all-deps.cmake is auto-generated by the Taskfile and sets <Package>_ROOT cache variables
# (e.g. fmt_ROOT, absl_ROOT) that point to pre-installed deps under build/deps/cpp/<pkg>-install/.
# CMake's find_package() searches <Package>_ROOT first; these variables ensure that all
# find_package() calls resolve to the Taskfile-installed versions rather than any system copies.
if(NOT DEFINED DEPS_CPP_DIR)
set(DEPS_CPP_DIR "${CMAKE_CURRENT_SOURCE_DIR}/build/deps/cpp")
endif()

include("${DEPS_CPP_DIR}/cmake-settings/all-deps.cmake" REQUIRED)

# ==============================================================================
# Presto/Velox framework headers
# ==============================================================================
Expand Down
26 changes: 26 additions & 0 deletions velox-connector/README.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
# Velox Connector


## Requirements

* CMake 3.28+
Comment thread
20001020ycx marked this conversation as resolved.
Resolved
* C++20 compatible compiler
* [Task] 3.38.0+

## Building

```shell
task velox-connector:build
```

Or with CMake directly:

```shell
task deps:install
cmake -S . -B build/velox-connector
cmake --build build/velox-connector -j
```
Comment thread
20001020ycx marked this conversation as resolved.
Resolved

The built plugin is at `build/velox-connector/libclp-plugin-velox-connector.so`.
Comment thread
20001020ycx marked this conversation as resolved.
Resolved

[Task]: https://taskfile.dev
Comment thread
coderabbitai[bot] marked this conversation as resolved.
Resolved
25 changes: 25 additions & 0 deletions velox-connector/taskfile.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
version: "3"

set: ["u", "pipefail"]
shopt: ["globstar"]

includes:
deps: "taskfiles/deps.yaml"
velox-connector: "taskfiles/velox-connector.yaml"

vars:
G_BUILD_DIR: "{{.ROOT_DIR}}/build"
G_VELOX_CONNECTOR_BUILD_DIR: "{{.G_BUILD_DIR}}/velox-connector"

G_DEPS_CPP_DIR: "{{.G_BUILD_DIR}}/deps/cpp"

tasks:
clean:
cmds:
- "rm -rf '{{.G_BUILD_DIR}}'"

init:
internal: true
silent: true
run: "once"
cmd: "mkdir -p '{{.G_BUILD_DIR}}'"
Loading