Repository navigation
feat: Add tasks to manage the connector's dependencies for the worker. #9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
20001020ycx
merged 24 commits into
y-scope:main
from
20001020ycx:feat/2026-05-22-velox-connector-taskfile
Jun 22, 2026
Merged
Changes from 3 commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
4e5228f
changes for taskfile infra
20001020ycx 20001f3
Merge branch 'main' into feat/2026-05-22-velox-connector-taskfile
20001020ycx b6fb0a3
add cmake change + nit changes on taskfiles
20001020ycx 01ad866
add missing EOF for the new files
20001020ycx 209850f
add missing reference in Readme and hash SHA256 update
20001020ycx 4f90b68
update cmake + deps + some submodule update
20001020ycx 3ea02f3
disable CLP-S archive writer
20001020ycx eca45b8
refactor: Move velox-connector taskfiles to repo root
20001020ycx 218d465
fix: Make deps tasks public so velox-connector:deps:install-all is ca…
20001020ycx e80f7c0
fix: Remove old velox-connector taskfile files (restored by earlier c…
20001020ycx f415e17
fix dependency
20001020ycx bb377d1
Merge branch 'main' of github.com:y-scope/clp-plugin-presto-connector…
20001020ycx 8908d75
adding clean task + review fixes
20001020ycx 27867b3
nits on README format
20001020ycx 9b4a0af
nits on cmakelist
20001020ycx 38a4b96
Pass CMake settings file path to CMake project rather than dependenci…
kirkrodrigues 4cca9cf
Apply suggestions from Kirk's review
20001020ycx ce4cc18
address Kirk's comment
20001020ycx 998f919
address jack's comment
20001020ycx 9422359
Apply suggestions from code review
20001020ycx b97bd93
code changes for addresssing Kirk's comment
20001020ycx 42d3d21
README update
20001020ycx 5bd5f09
Update velox-connector/README.md
20001020ycx da8256d
Update velox-connector/README.md
20001020ycx File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| [submodule "velox-connector/tools/yscope-dev-utils"] | ||
| path = velox-connector/tools/yscope-dev-utils | ||
| url = https://github.com/y-scope/yscope-dev-utils.git |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| # Velox Connector | ||
|
|
||
|
|
||
| ## Requirements | ||
|
|
||
| * CMake 3.28+ | ||
| * C++20 compatible compiler | ||
| * [Task] 3.38.0+ | ||
|
|
||
| ## Building | ||
|
|
||
| ```shell | ||
| task velox-connector:build | ||
| ``` | ||
|
|
||
| Or with CMake directly: | ||
|
|
||
| ```shell | ||
| task deps:install | ||
| cmake -S . -B build/velox-connector | ||
| cmake --build build/velox-connector -j | ||
| ``` | ||
|
20001020ycx marked this conversation as resolved.
Resolved
|
||
|
|
||
| The built plugin is at `build/velox-connector/libclp-plugin-velox-connector.so`. | ||
|
20001020ycx marked this conversation as resolved.
Resolved
|
||
|
|
||
| [Task]: https://taskfile.dev | ||
|
coderabbitai[bot] marked this conversation as resolved.
Resolved
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| version: "3" | ||
|
|
||
| set: ["u", "pipefail"] | ||
| shopt: ["globstar"] | ||
|
|
||
| includes: | ||
| deps: "taskfiles/deps.yaml" | ||
| velox-connector: "taskfiles/velox-connector.yaml" | ||
|
|
||
| vars: | ||
| G_BUILD_DIR: "{{.ROOT_DIR}}/build" | ||
| G_VELOX_CONNECTOR_BUILD_DIR: "{{.G_BUILD_DIR}}/velox-connector" | ||
|
|
||
| G_DEPS_CPP_DIR: "{{.G_BUILD_DIR}}/deps/cpp" | ||
|
|
||
| tasks: | ||
| clean: | ||
| cmds: | ||
| - "rm -rf '{{.G_BUILD_DIR}}'" | ||
|
|
||
| init: | ||
| internal: true | ||
| silent: true | ||
| run: "once" | ||
| cmd: "mkdir -p '{{.G_BUILD_DIR}}'" |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.