Repository navigation
chore(velox-connector): Remove the C++ tests that were never built. - #64
Open
jackluo923 wants to merge 23 commits into
Open
jackluo923 wants to merge 23 commits into
jackluo923 wants to merge 23 commits into
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
jackluo923
force-pushed
the
stack/integration-tests/10-remove-cpp-tests
branch
2 times, most recently
from
August 4, 2026 02:29
cd9ea8f to
0b74ad3
Compare
jackluo923
force-pushed
the
stack/integration-tests/10-remove-cpp-tests
branch
from
August 4, 2026 02:34
0b74ad3 to
4f815e1
Compare
jackluo923
force-pushed
the
stack/integration-tests/10-remove-cpp-tests
branch
2 times, most recently
from
August 4, 2026 03:19
0324d12 to
5ca430e
Compare
jackluo923
force-pushed
the
stack/integration-tests/10-remove-cpp-tests
branch
from
August 4, 2026 03:31
5ca430e to
425b1d1
Compare
jackluo923
force-pushed
the
stack/integration-tests/10-remove-cpp-tests
branch
2 times, most recently
from
August 4, 2026 04:16
62c027f to
f2b9d50
Compare
jackluo923
force-pushed
the
stack/integration-tests/10-remove-cpp-tests
branch
2 times, most recently
from
August 4, 2026 04:56
006c337 to
fb97f1c
Compare
jackluo923
force-pushed
the
stack/integration-tests/10-remove-cpp-tests
branch
from
August 4, 2026 05:08
fb97f1c to
f53c675
Compare
jackluo923
force-pushed
the
stack/integration-tests/10-remove-cpp-tests
branch
2 times, most recently
from
August 4, 2026 08:04
59e63e4 to
1b836ca
Compare
jackluo923
changed the base branch from
stack/integration-tests/09-test-ci
to
stack/integration-tests/09b-s3-storage
August 4, 2026 08:07
jackluo923
force-pushed
the
stack/integration-tests/10-remove-cpp-tests
branch
from
August 4, 2026 08:44
1b836ca to
23a9358
Compare
jackluo923
changed the base branch from
stack/integration-tests/09b-s3-storage
to
stack/integration-tests/11-cpp-unit-tests
August 4, 2026 08:45
jackluo923
force-pushed
the
stack/integration-tests/10-remove-cpp-tests
branch
from
August 4, 2026 08:46
23a9358 to
00d735e
Compare
jackluo923
force-pushed
the
stack/integration-tests/10-remove-cpp-tests
branch
2 times, most recently
from
August 5, 2026 19:51
7357854 to
ce34c77
Compare
Removes `ClpConnectorTest.cpp`, `ClpConfigTest.cpp`, and the 13 example archives they read. No `CMakeLists.txt` has ever referenced them. They arrived with the initial plugin commit and were never compiled or run, because the plugin is a shared library that deliberately leaves Velox symbols undefined for the worker to resolve at load time: a test binary has nothing to link against, and building one would mean compiling Velox into the build-env image. Their cases are covered now. The read-path and pushdown ones run as SQL against a live worker in the integration tests, and the S3 auth and URL ones, which no SQL can reach, run as unit tests alongside the connector's Velox-free headers. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
jackluo923
force-pushed
the
stack/integration-tests/10-remove-cpp-tests
branch
from
August 5, 2026 20:11
ce34c77 to
8c3c860
Compare
…n-tests/10-remove-cpp-tests.
…n-tests/10-remove-cpp-tests.
…n-tests/10-remove-cpp-tests.
…n-tests/10-remove-cpp-tests.
…n-tests/10-remove-cpp-tests.
…n-tests/10-remove-cpp-tests.
…n-tests/10-remove-cpp-tests.
…n-tests/10-remove-cpp-tests.
…n-tests/10-remove-cpp-tests.
…n-tests/10-remove-cpp-tests.
…n-tests/10-remove-cpp-tests.
…n-tests/10-remove-cpp-tests.
…n-tests/10-remove-cpp-tests.
20001020ycx
approved these changes
Aug 7, 2026
…n-tests/10-remove-cpp-tests.
…n-tests/10-remove-cpp-tests.
…n-tests/10-remove-cpp-tests.
…n-tests/10-remove-cpp-tests.
…n-tests/10-remove-cpp-tests.
…n-tests/10-remove-cpp-tests.
…n-tests/10-remove-cpp-tests.
…n-tests/10-remove-cpp-tests.
…n-tests/10-remove-cpp-tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Removes
ClpConnectorTest.cpp,ClpConfigTest.cpp, and the 13 example archives that they read.No
CMakeLists.txtreferences them, so they have never been built. Wiring them up is impractical: the plugin leaves Velox symbols undefined so that the worker process resolves them at load time, which leaves a test binary with nothing to link against unless Velox is compiled into the build-env image.Their cases are covered by the integration tests, and by the
velox-connector/tests/unit tests that this branch already carries.Breaking changes
None.
Validation performed
git grepfinds no remaining reference to the deleted files or theirexamples/directory.task velox-connector:test: 11 passed.task integration-tests:run: 24 passed, 2 xfailed.Checklist
(fixes #N)or(resolves #N)syntax in the title.