build: Switch from y-scope/presto to prestodb/presto@6e1942 which has equivalent functionality. - #14
Merged
Merged
Conversation
|
Caution Review failedAn error occurred during the review process. Please try again later. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
jackluo923
force-pushed
the
build/adapt-plugin-to-upstream-pin
branch
from
June 22, 2026 22:21
71fcdea to
78fc40c
Compare
Member
|
@coderabbitai review |
✅ Action performedReview finished.
|
20001020ycx
reviewed
Jun 23, 2026
20001020ycx
previously approved these changes
Jun 23, 2026
20001020ycx
left a comment
Collaborator
There was a problem hiding this comment.
One comment for nit, the changes LGTM as I also have the same patch applied to the private repo.
…stream pin. Repoints velox-connector's CMake FetchContent of presto_native_execution from the y-scope/presto fork to prestodb/presto and lifts the presto SHA into a single `set(PRESTO_GIT_TAG ...)` line so a presto bump is a one-line change. That same line is read by tools/build-packages/dependency-image/lib.sh to derive the velox SHA for the build-env image. Adds serialize/deserialize stubs for ConnectorDistributedProcedureHandle in ClpConnectorProtocol.h — the newer upstream ConnectorProtocol base class declares them as pure virtuals, so without these the plugin wouldn't compile against the new pin. Both stubs throw VELOX_NYI consistent with the existing to_json/from_json stubs above them.
jackluo923
force-pushed
the
build/adapt-plugin-to-upstream-pin
branch
from
June 23, 2026 13:51
78fc40c to
537c76b
Compare
jackluo923
commented
Jun 23, 2026
kirkrodrigues
approved these changes
Jun 23, 2026
kirkrodrigues
left a comment
Member
There was a problem hiding this comment.
For the PR title, how about:
build: Switch from `y-scope/presto` to prestodb/presto@6e1942 which has equivalent functionality.
y-scope/presto to prestodb/presto@6e1942 which has equivalent functionality.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Repoint the velox-connector's CMake
FetchContentofpresto_native_executionfrom they-scope/prestofork toprestodb/prestoupstream, and lift the presto SHA into a singleset(PRESTO_GIT_TAG ...)variable so a presto bump is a one-line change.Also adds
serialize/deserializestubs forConnectorDistributedProcedureHandleinClpConnectorProtocol.h— the newer upstreamConnectorProtocolbase class declares them as pure virtuals, so without these stubs the plugin won't compile against the new pin. Both stubs throwVELOX_NYI, consistent with the existingto_json/from_jsonstubs above them.Breaking changes
None
Validation performed
prestodb/prestopin and verified it compiles successfully.PRESTO_GIT_TAGis referenced in a single place and that theFetchContent_Declareuses the variable.Checklist
(fixes #N)or(resolves #N)syntax in the title.Summary by CodeRabbit