Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Fix workflow failure caused by missing Python 3.7 in the latest macOS runner. #42

Merged
merged 7 commits into from
Nov 29, 2024
Merged

ci: Fix workflow failure caused by missing Python 3.7 in the latest macOS runner. #42

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
cbcf9b5
Apply the fix
LinZhihao-723 Nov 28, 2024
568292d
Add Python3.7 as a stand-alone test
LinZhihao-723 Nov 28, 2024
5052006
Fix errors
LinZhihao-723 Nov 28, 2024
3d6a315
Fix the wheel resolving
LinZhihao-723 Nov 28, 2024
2721d6a
Remove redundant section
LinZhihao-723 Nov 28, 2024
f974a51
Add comment
LinZhihao-723 Nov 28, 2024
283e6b7
Update .github/workflows/package.yaml
LinZhihao-723 Nov 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 25 additions & 5 deletions .github/workflows/package.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,12 +38,12 @@ jobs:
path: dist/*
retention-days: 1

test:
test-python37:
needs: [build]
strategy:
matrix:
os: [macos-latest, ubuntu-latest]
python-version: ["3.7", "3.8", "3.11"]
os: [macos-13, ubuntu-latest]
python-version: ["3.7"]
runs-on: ${{ matrix.os }}
steps:
- uses: actions/checkout@v3
Expand All @@ -53,14 +53,34 @@ jobs:
python-version: ${{ matrix.python-version }}

- name: Download wheels for Python3.7
if: ${{ '3.7' == matrix.python-version }}
uses: actions/download-artifact@v3
with:
# Since we don't build for Python 3.7, we download the Python 3.8 wheel instead.
name: wheel-3.8
path: dist/

- run: pip install --upgrade
pip
dist/clp_logging-*.whl
-r requirements-test.txt

- run: python -m unittest -fv

test:
needs: [build]
strategy:
matrix:
os: [macos-latest, ubuntu-latest]
python-version: ["3.8", "3.11"]
runs-on: ${{ matrix.os }}
steps:
- uses: actions/checkout@v3

- uses: actions/setup-python@v4
with:
python-version: ${{ matrix.python-version }}
Comment on lines +77 to +81
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

Update GitHub Actions to latest versions

Several actions are using older versions. Consider updating to the latest stable versions for improved security and features:

-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4

-      - uses: actions/setup-python@v4
+      - uses: actions/setup-python@v5
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
- uses: actions/checkout@v3
- uses: actions/setup-python@v4
with:
python-version: ${{ matrix.python-version }}
- uses: actions/checkout@v4
- uses: actions/setup-python@v5
with:
python-version: ${{ matrix.python-version }}
🧰 Tools
🪛 actionlint (1.7.4)

76-76: the runner of "actions/checkout@v3" action is too old to run on GitHub Actions. update the action's version to fix this issue

(action)

78-78: the runner of "actions/setup-python@v4" action is too old to run on GitHub Actions. update the action's version to fix this issue

(action)


- name: Download wheels for Built Python Versions
if: ${{ '3.7' != matrix.python-version }}
uses: actions/download-artifact@v3
with:
name: wheel-${{ matrix.python-version }}
Expand Down
Loading