-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace dateutil.tz with ZoneInfo and tzlocal for better cross-platform compatibility. #40
Merged
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
0dfdd1a
Replace dateutil.tz with ZoneInfo and tzlocal.
junhaoliao 172a9e0
Reformat code; add backports.zoneinfo for Python version < 3.9.
junhaoliao 8d05f3c
Reformat code.
junhaoliao 93c2e8f
Try to fix mypy error.
junhaoliao f79c492
Update pyproject.toml
junhaoliao 45c0f2b
Update pyproject.toml
junhaoliao 081a5de
Fall back to "UTC" when Exception occurs in getting local timezone name.
junhaoliao 2b79bff
Set tzlocal package version requirement depending on Python version.
junhaoliao 151198f
Replaced abstract tzinfo with ZoneInfo as a concrete type.
junhaoliao b925550
Merge branch 'main' into tz_win
junhaoliao File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The class
ZoneInfo
is an implementation oftzinfo
abstracted class, shall we narrow down the type ofself.timezone
toZoneInfo
instead?This means we should also update the type annotation in
Log._decode