-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix clang-tidy warnings for all C++ source files #96
Labels
enhancement
New feature or request
Comments
clang-tidy enabled in #99 |
This was referenced Dec 2, 2024
This was referenced Jan 5, 2025
Merged
This was referenced Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Request
Until 0c66d04, we have clang-tidy added to the linting tasks but disabled due to unresolved clang-tidy warnings across all C++ source files.
We should gradually resolve all these warnings.
Possible implementation
We shall send a serious of PRs to fix the warnings. Before all warnings are fixed, we should modify the lint task to only execute clang-tidy against fixed files (as discussed here). Eventually, we should have warnings resolved across all files, and we can set the lint task to run on all files (back to the config in 0c66d04)
New linting changes introduced to fix linting issues:
Py_utils
. #95wrapped_dependency_headers
in parallel toclp_ffi_py
Python.hpp
introduced in feat: Add Python classKeyValuePairLogEvent
as a wrapper ofclp::ffi::KeyValuePairLogEvent
. #81:clp_ffi_py
whenCLP_FFI_PY_ENABLE_LINTING
is definedutils
. #101PyKeyValuePairLogEvent
. #108.The text was updated successfully, but these errors were encountered: