Use emsdk's install script rather than cloning a specific release.

[kirkrodrigues]

Description

#7 locked emsdk's version to 3.1.67 but used git to clone the release rather than using emsdk's built-in install functionality. This PR switches to the latter.

Validation performed

Ran the reproduction instructions in #6 and verified the build succeeded.

Summary by CodeRabbit

• Chores
  • Updated the emsdk task to lock the version to "3.1.67" for improved stability.
  • Simplified the cloning process for the emsdk repository.
  • Enhanced checksum validation for better accuracy.
  • Added comments for clarity on changes made.

[coderabbitai]

Warning

Rate limit exceeded

@kirkrodrigues has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 19 minutes and 37 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Files that changed from the base of the PR and between 3c2fb05 and 62d36e1.

Walkthrough

The changes in the pull request focus on the Taskfile.yml, specifically modifying the emsdk task to introduce a new variable, EMSDK_VERSION, set to "3.1.67". This version lock aims to address specific issues with the emsdk. The repository cloning process has been simplified by removing unnecessary options, and the checksum validation has been refined to exclude additional paths. Comments have been added for clarity, while the overall task structure remains unchanged.

Changes

File	Change Summary
Taskfile.yml	Introduced EMSDK_VERSION variable set to "3.1.67"; simplified cloning command and updated checksum validation. Added comments for clarity.

Possibly related PRs

• Temporarily lock emsdk version to 3.1.67 to work around #6. #7: This PR also focuses on locking the emsdk version to "3.1.67" in Taskfile.yml, directly relating to the changes made in the main PR regarding the EMSDK_VERSION variable and the handling of the emsdk repository.

Suggested reviewers

• davemarco
• LinZhihao-723

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 1

🧹 Outside diff range and nitpick comments (1)

Taskfile.yml (1)

63-64: LGTM! Consider adding a link to the issue.

The addition of the EMSDK_VERSION variable is a good practice for version management. It aligns well with the PR objectives and improves maintainability.

Consider adding a link to issue #6 in the comment for easier reference:

# Lock emsdk to version 3.1.67 to work around issue #6 (https://github.com/y-scope/clp-ffi-js/issues/6).

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between d8fac7b and 3c2fb05.

📒 Files selected for processing (1)

• Taskfile.yml (2 hunks)

🧰 Additional context used

🪛 yamllint

Taskfile.yml

[error] 89-89: trailing spaces

(trailing-spaces)

🔇 Additional comments (2)

Taskfile.yml (2)

Line range hint 74-82: LGTM! Checksum exclusions look appropriate.

The updates to the EXCLUDE_PATHS for the emsdk checksum are well-considered. These exclusions should help reduce false positives in the checksum validation process by ignoring frequently changing or irrelevant files and directories.

---

Line range hint 1-134: Summary: Changes improve maintainability and align with PR objectives.

The modifications to Taskfile.yml successfully implement the PR objectives:

1. Introduction of EMSDK_VERSION variable improves version management.
2. Updated emsdk installation process uses the official install script, enhancing maintainability.
3. Refined checksum exclusions should reduce false positives in validation.

These changes collectively streamline the setup process and make future updates easier to manage.

🧰 Tools

🪛 yamllint

[error] 89-89: trailing spaces

(trailing-spaces)

[junhaoliao]

I was able to replicate the issue with 3.1.68 and the changes in this PR was validated on a Mac computer. The changes look lgtm and the PR title is suitable for the final commit message.