Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split StreamReader into an interface and implementation to prepare for adding another IR stream reader. #26

Merged
merged 42 commits into from
Nov 7, 2024
Merged
Show file tree
Hide file tree
Changes from 37 commits
Commits
Show all changes
42 commits
Select commit Hold shift + click to select a range
3dae806
Refactor StreamReader to modularize decoding logic.
junhaoliao Oct 15, 2024
ab32045
Add a comment section for methods in StreamReader.hpp.
junhaoliao Oct 15, 2024
8dc3dff
Add `get_version` to decoding methods.
junhaoliao Oct 15, 2024
eba1d30
Move `#include <emscripten/bind.h>` from StreamReader.hpp to StreamRe…
junhaoliao Oct 15, 2024
5398d1d
Rename StreamReader -> IRStreamReader.
junhaoliao Oct 15, 2024
cfd55ca
Rename ClpIrStreamReader to ClpIRStreamReader in bindings.
junhaoliao Oct 15, 2024
d1ed2f0
Extract a StreamReader base class from IRStreamReader.
junhaoliao Oct 15, 2024
bf5e4c9
Rename IRStreamReader -> IrStreamReader.
junhaoliao Oct 15, 2024
ad306f2
merging main into junhao PR
davemarco Oct 31, 2024
c474bb4
some restructure
davemarco Nov 1, 2024
f4a6896
fix cmake
davemarco Nov 1, 2024
dba3910
more changes after test
davemarco Nov 1, 2024
9ddd974
junhao changes
davemarco Nov 4, 2024
a5cb529
fix lint
davemarco Nov 4, 2024
cd50c9a
version methodology change + better error handling
davemarco Nov 4, 2024
d2cf122
lint fix
davemarco Nov 4, 2024
7fe3a58
Update src/clp_ffi_js/ir/decoding_methods.hpp
davemarco Nov 5, 2024
9b67be9
fix print statement
davemarco Nov 5, 2024
fb2b290
fix lint
davemarco Nov 5, 2024
464cf31
forgot one comment, adding type for log level filter
davemarco Nov 5, 2024
6e8d025
Update src/clp_ffi_js/ir/StreamReader.hpp
davemarco Nov 5, 2024
19e41b9
Update src/clp_ffi_js/ir/StreamReader.cpp
davemarco Nov 5, 2024
4988949
Update src/clp_ffi_js/ir/decoding_methods.hpp
davemarco Nov 5, 2024
c79a83f
kirk review comments
davemarco Nov 5, 2024
ef0b86b
fix lint
davemarco Nov 5, 2024
d9e9e97
Apply suggestions from code review
davemarco Nov 6, 2024
efaeedd
kirk review
davemarco Nov 6, 2024
3764298
rename
davemarco Nov 6, 2024
c81cd4b
cleanup
davemarco Nov 6, 2024
28d4250
fix seek issue
davemarco Nov 6, 2024
c5db9a6
Update src/clp_ffi_js/ir/StreamReader.cpp
davemarco Nov 6, 2024
4a83bce
Update src/clp_ffi_js/ir/StreamReader.hpp
davemarco Nov 6, 2024
de7a2f8
Update src/clp_ffi_js/ir/StreamReader.hpp
davemarco Nov 6, 2024
1b31f08
Apply suggestions from code review
davemarco Nov 6, 2024
226ab3a
Update src/clp_ffi_js/ir/StreamReader.cpp
davemarco Nov 6, 2024
fa4debd
change to pass by value
davemarco Nov 6, 2024
4108398
kirk changes
davemarco Nov 6, 2024
c7a8fbf
change submodule
davemarco Nov 6, 2024
d5cad52
Merge branch 'main' into extractBaseClass
davemarco Nov 6, 2024
bfea301
Apply suggestions from code review
davemarco Nov 6, 2024
72bdf6e
revert submodule change
davemarco Nov 6, 2024
119de6c
use see
davemarco Nov 7, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -113,8 +113,8 @@ target_include_directories(
target_include_directories(${CLP_FFI_JS_BIN_NAME} PRIVATE src/)

set(CLP_FFI_JS_SRC_MAIN
src/clp_ffi_js/ir/decoding_methods.cpp
src/clp_ffi_js/ir/StreamReader.cpp
src/clp_ffi_js/ir/UnstructuredIrStreamReader.cpp
)

set(CLP_FFI_JS_SRC_CLP_CORE
Expand Down
2 changes: 1 addition & 1 deletion src/clp_ffi_js/.clang-format
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ IncludeCategories:
Priority: 4
# Library headers. Update when adding new libraries.
# NOTE: clang-format retains leading white-space on a line in violation of the YAML spec.
- Regex: "<(emscripten|fmt|spdlog)"
- Regex: "<(emscripten|fmt|spdlog|json)"
davemarco marked this conversation as resolved.
Show resolved Hide resolved
Priority: 3
- Regex: "^<(clp)"
Priority: 3
Expand Down
Loading
Loading