Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: kirkrodrigues <[email protected]>
  • Loading branch information
davemarco and kirkrodrigues authored Nov 6, 2024
1 parent d5cad52 commit bfea301
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 1 deletion.
2 changes: 1 addition & 1 deletion src/clp_ffi_js/.clang-format
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ IncludeCategories:
Priority: 4
# Library headers. Update when adding new libraries.
# NOTE: clang-format retains leading white-space on a line in violation of the YAML spec.
- Regex: "<(emscripten|fmt|spdlog|json)"
- Regex: "<(emscripten|fmt|json|spdlog)"
Priority: 3
- Regex: "^<(clp)"
Priority: 3
Expand Down
2 changes: 2 additions & 0 deletions src/clp_ffi_js/ir/StreamReader.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -158,6 +158,7 @@ auto StreamReader::create(DataArrayTsType const& data_array) -> std::unique_ptr<
zstd_decompressor->open(data_buffer.data(), length);

rewind_reader_and_validate_encoding_type(*zstd_decompressor);

// Validate the stream's version
auto pos = zstd_decompressor->get_pos();
auto const version{get_version(*zstd_decompressor)};
Expand All @@ -179,6 +180,7 @@ auto StreamReader::create(DataArrayTsType const& data_array) -> std::unique_ptr<
std::format("Unable to rewind zstd decompressor: {}", e.what())
};
}

return std::make_unique<UnstructuredIrStreamReader>(
UnstructuredIrStreamReader::create(std::move(zstd_decompressor), std::move(data_buffer))
);
Expand Down

0 comments on commit bfea301

Please sign in to comment.