Implements move_to #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Waidhoferj
reviewed
Oct 26, 2022
There was a problem hiding this comment.
Hi @hbcarlos, thanks for adding move functionality! This looks good so far. Let me know if you have any questions about the codebase.
@Horusiath could you double check this?
src/y_array.rs
Outdated
| SharedType::Integrated(v) => Ok(v.move_to(txn, source, target)), | ||
| SharedType::Prelim(v) if source < v.len() as u32 && target < v.len() as u32 => { | ||
| if source < 0 as u32 || target < 0 as u32 { | ||
| Err::<PyIndexError, ()>(()); |
There was a problem hiding this comment.
Suggested change
| Err::<PyIndexError, ()>(()); | |
| Err(PyIndexError::default_message()) |
Including a default message or specifically referencing whether source or target is out of bounds would be helpful.
|
Hey @Waidhoferj! Thank you so much for the help! I added a new commit with your suggestion and the implementation of |
|
Hi @hbcarlos, looks good! Could you add test cases covering these functions to |
|
I added some tests in my last commit. |
Waidhoferj
approved these changes
Nov 5, 2022
|
Thanks, @Waidhoferj! I don't have maintainer rights, I can not merge it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @Waidhoferj.
I noticed the move feature had not yet been implemented here in the python bindings. I trying to implement it since we need it for JupyterLab.
Can you take a look at this? It is the first time I have looked at y-rs and y-py, and the first time I used rust, so I'm unsure if I'm implementing it correctly.
I'm keeping the PR as a draft because I want to implement
move_range_toin the same PR, but first, I would like you to take a look at themove_tofunction in case I'm doing something wrong.