Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add metadata column to SQLiteYStore, fix update broadcast #42

Merged
merged 5 commits into from
Nov 17, 2022
Merged

Add metadata column to SQLiteYStore, fix update broadcast #42

merged 5 commits into from
Nov 17, 2022

Conversation

davidbrochart
Copy link
Collaborator

@davidbrochart davidbrochart commented Nov 16, 2022 •
edited
Loading

Closes #40.

@davidbrochart davidbrochart mentioned this pull request Nov 16, 2022
Merged
fcollonval
fcollonval requested changes Nov 16, 2022
View reviewed changes
ypy_websocket/websocket_server.py Outdated Show resolved Hide resolved
ypy_websocket/websocket_server.py Outdated Show resolved Hide resolved
ypy_websocket/websocket_server.py Outdated Show resolved Hide resolved
ypy_websocket/ydoc.py Outdated Show resolved Hide resolved
@davidbrochart
Copy link
Collaborator Author

I think tests fail because of y-crdt/ypy#94.

@davidbrochart
Copy link
Collaborator Author

I think tests fail because of y-crdt/ypy#94.

My bad, fixed in 3b57fbc.

@davidbrochart davidbrochart merged commit aa18801 into y-crdt:main Nov 17, 2022
This was referenced Nov 17, 2022
Closed
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fcollonval fcollonval fcollonval requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Inefficiencies and correctness of sqlite db reads and writes
2 participants
@davidbrochart @fcollonval