Repository navigation
Fix terminal find bar swallowing IME Enter key - #1
Closed
y-agatsuma wants to merge 1 commit into
Closed
y-agatsuma wants to merge 1 commit into
y-agatsuma wants to merge 1 commit into
Conversation
Replace .backport.onKeyPress(.return) with .onSubmit so that Enter during IME composition confirms the input instead of triggering find-next. Matches the browser find bar fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the terminal find bar intercepting Enter during Japanese IME composition, causing the input to be lost instead of confirmed.
Stacked on manaflow-ai#875.
Changes
.backport.onKeyPress(.return)with.onSubmitinSurfaceSearchOverlayonSubmitonly fires after IME composition is committed, so Enter correctly confirms inputNSEvent.modifierFlagscheckTest plan
Screeshot
https://cleanshot.com/share/S7PcQwKj