1.0.0-alpha #19
Merged
1.0.0-alpha #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nto xycloans-0.2.0 Merging workflow file
heytdep
commented
Jul 30, 2023
pool/src/balance.rs
Outdated
| let mut balance = read_balance(e, to.clone()); | ||
|
|
||
| // if addr is burning all the shares then remove every particular data associated with addr | ||
| if balance == shares { |
There was a problem hiding this comment.
This block is not needed anymore given state expiration and is also faulty as it results in the address losing its matured rewards.
|
Current TODOs:
For 0.3.0:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This version brings updates and optimization to the protocol.