Skip to content

Commit

Permalink
extending ContainerAware is deprecated since symfony version 2.8 (#6)
Browse files Browse the repository at this point in the history
* extending ContainerAware is deprecated since symfony version 2.8, and removed in 3.0
* updated symfony component requirements

* updated symfony version, package version

* removed symfony version string vom composer.json
  • Loading branch information
toooni authored and xyNNN committed Apr 18, 2016
1 parent 13da711 commit 54e53d8
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 8 deletions.
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ The GoogleTagManagerBundle provides you an easy-to-use method to integrate the G
## Requirements

- [x] PHP 5.3 and higher
- [x] Symfony 2.0 and higher
- [x] Symfony 2.8 and higher

## Install

Expand All @@ -20,7 +20,7 @@ Open a command console, enter your project directory and execute the
following command to download the latest stable version of this bundle:

```bash
$ composer require xynnn/google-tag-manager-bundle "~1.0"
$ composer require xynnn/google-tag-manager-bundle "~2.0"
```

This command requires you to have Composer installed globally, as explained
Expand Down
6 changes: 4 additions & 2 deletions Service/GoogleTagManagerFactory.php
Original file line number Diff line number Diff line change
Expand Up @@ -10,16 +10,18 @@

namespace Xynnn\GoogleTagManagerBundle\Service;

use Symfony\Component\DependencyInjection\ContainerAware;
use Symfony\Component\DependencyInjection\ContainerAwareTrait;
use Symfony\Component\DependencyInjection\ContainerInterface;

/**
* Class GoogleTagManagerFactory
*
* @package Xynnn\GoogleTagManagerBundle\Service
*/
class GoogleTagManagerFactory extends ContainerAware
class GoogleTagManagerFactory
{
use ContainerAwareTrait;

/**
* @return ContainerInterface
*/
Expand Down
8 changes: 4 additions & 4 deletions composer.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "xynnn/google-tag-manager-bundle",
"type": "symfony-bundle",
"description": "Google Tag Manager Bundle for Symfony 2",
"description": "Google Tag Manager Bundle for Symfony",
"keywords": ["Google Tag Manager", "Tag Manager"],
"homepage": "https://github.com/xyNNN/GoogleTagManagerBundle",
"license": "GNU LGPL v3.0",
Expand All @@ -14,9 +14,9 @@
"minimum-stability": "dev",
"require": {
"php": ">=5.3.2",
"symfony/dependency-injection": "~2.3",
"symfony/http-kernel": "~2.3",
"symfony/config": "~2.3"
"symfony/dependency-injection": "~2.8|~3.0",
"symfony/http-kernel": "~2.8|~3.0",
"symfony/config": "~2.8|~3.0"
},
"require-dev": {
"phpunit/phpunit": "~4.3"
Expand Down

0 comments on commit 54e53d8

Please sign in to comment.