refactor: tag

xxxsen · Aug 19, 2024 · 3478a6f · 3478a6f
1 parent 3e86a33
commit 3478a6f
Show file tree

Hide file tree

Showing 5 changed files with 28 additions and 26 deletions.
diff --git a/constant/constant.go b/constant/constant.go
diff --git a/number/constant.go b/number/constant.go
@@ -6,3 +6,10 @@ const (
 	defaultSuffix4K              = "4K"
 	defaultSuffixMultiCD         = "CD"
 )
+
+const (
+	defaultTagUncensored      = "无码"
+	defaultTagChineseSubtitle = "中文字幕"
+	defaultTag4K              = "4K"
+	defaultTagLeak            = "无码流出"
+)
diff --git a/number/model.go b/number/model.go
@@ -1,6 +1,8 @@
 package number
 
-import "strconv"
+import (
+	"strconv"
+)
 
 type Number struct {
 	number            string
@@ -56,6 +58,23 @@ func (n *Number) GenerateSuffix(base string) string {
 	return base
 }
 
+func (n *Number) GenerateTags() []string {
+	rs := make([]string, 0, 5)
+	if n.GetIsUncensorMovie() {
+		rs = append(rs, defaultTagUncensored)
+	}
+	if n.GetIsChineseSubtitle() {
+		rs = append(rs, defaultTagChineseSubtitle)
+	}
+	if n.GetIs4K() {
+		rs = append(rs, defaultTag4K)
+	}
+	if n.GetIsLeak() {
+		rs = append(rs, defaultTagLeak)
+	}
+	return rs
+}
+
 func (n *Number) GenerateFileName() string {
 	return n.GenerateSuffix(n.GetNumberID())
 }
diff --git a/processor/handler/tag_padder.go b/processor/handler/tag_padder.go
@@ -2,26 +2,14 @@ package handler
 
 import (
 	"context"
-	"yamdc/constant"
 	"yamdc/model"
 	"yamdc/utils"
 )
 
 type tagPadder struct{}
 
 func (h *tagPadder) Handle(ctx context.Context, fc *model.FileContext) error {
-	if fc.Number.GetIsUncensorMovie() {
-		fc.Meta.Genres = append(fc.Meta.Genres, constant.TagUncensored)
-	}
-	if fc.Number.GetIsChineseSubtitle() {
-		fc.Meta.Genres = append(fc.Meta.Genres, constant.TagChineseSubtitle)
-	}
-	if fc.Number.GetIs4K() {
-		fc.Meta.Genres = append(fc.Meta.Genres, constant.Tag4K)
-	}
-	if fc.Number.GetIsLeak() {
-		fc.Meta.Genres = append(fc.Meta.Genres, constant.TagLeak)
-	}
+	fc.Meta.Genres = append(fc.Meta.Genres, fc.Number.GenerateTags()...)
 	fc.Meta.Genres = utils.DedupStringList(fc.Meta.Genres)
 	return nil
 }

diff --git a/processor/handler/tag_padder_test.go b/processor/handler/tag_padder_test.go
@@ -3,7 +3,6 @@ package handler
 import (
 	"context"
 	"testing"
-	"yamdc/constant"
 	"yamdc/model"
 	"yamdc/number"
 
@@ -20,7 +19,4 @@ func TestTagPadde(t *testing.T) {
 	}
 	padder.Handle(context.Background(), fc)
 	assert.Equal(t, 3, len(fc.Meta.Genres))
-	assert.Contains(t, fc.Meta.Genres, constant.Tag4K)
-	assert.Contains(t, fc.Meta.Genres, constant.TagChineseSubtitle)
-	assert.Contains(t, fc.Meta.Genres, constant.TagUncensored)
 }