Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documented the case where a Fragment may rerun onAttach() and onCreate() #31

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

yorickhenning
Copy link

Documented the case where a Fragment is popped from a FragmentManager's back stack and reused. This causes the Fragment to recreate its child FragmentManager, reattach, and run onCreate() again.

It is not obvious that this might happen, but it can.

FWIW, this reinitialization causes the FragmentManager returned by Fragment.getChildFragmentManager() to change, making it unsafe to store the FragmentManager reference across this change in the Fragment.

…'s back stack and reused. This causes the Fragment to recreate its child FragmentManager, reattach, and run onCreate() again.
Copy link

@kurtisnelson kurtisnelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants