Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use pointer to the container for int_vector_buffer iterator #120

Merged
merged 2 commits into from
Sep 11, 2023

Conversation

cartoonist
Copy link

Using reference member prevents defining assignment operator for the iterator class of int_vector_buffer. This commit fixes issue simongog#436 (the same PR is still open in Simon's fork but it is merged in vgteam's fork).

On a completely different note, I noticed that the assign interface functions (in utils.hpp) are removed (I mean these functions). Is there any specific reason why they are removed?

Using reference member prevents defining assignment operator for the
iterator class of int_vector_buffer. This commit fixes issue
vgteam/sdsl-lite#436.
@eseiler eseiler self-requested a review August 23, 2023 08:38
include/sdsl/int_vector_buffer.hpp Outdated Show resolved Hide resolved
include/sdsl/int_vector_buffer.hpp Show resolved Hide resolved
@eseiler eseiler enabled auto-merge (squash) September 11, 2023 10:29
@eseiler
Copy link
Collaborator

eseiler commented Sep 11, 2023

Thank you for the PR!

On a completely different note, I noticed that the assign interface functions (in utils.hpp) are removed (I mean these functions). Is there any specific reason why they are removed?

It was removed quite a while ago: 8054784

The reason seems to have been that move/copy assignment works just as well.
Do you have other use cases for the util::assign function?

@eseiler eseiler merged commit ec4cedc into xxsds:master Sep 11, 2023
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants