Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

修复自定义查询 in 查询bug #167

Merged
merged 3 commits into from
Sep 9, 2021
Merged

修复自定义查询 in 查询bug #167

merged 3 commits into from
Sep 9, 2021

Conversation

windha
Copy link
Contributor

@windha windha commented Sep 9, 2021

No description provided.

@xxjwxc xxjwxc merged commit 47a40ac into xxjwxc:master Sep 9, 2021
@xxjwxc
Copy link
Owner

xxjwxc commented Sep 9, 2021

貌似不能简单的去掉 ...
如果需要支持 in,not in 的话,就需要value 多参数

@windha
Copy link
Contributor Author

windha commented Sep 9, 2021

貌似不能简单的去掉 ...
如果需要支持 in,not in 的话,就需要value 多参数

我也注意到了,一般都是通过传递一个切片给value,不会穷举参数,穷举参数太麻烦了 ,虽然传参可以通过value... 进行解压缩切片,但是会报类型错误 类似于 cannot use s (type []int) as type []interface {} in argument ,可以把参数改成[]interface{} 再进行解压缩没有问题,但是这样缺少了类型信息.
所以value 不用可变长参数我觉得是合理的。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants