Skip to content

some connector test cleaned up. #1188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dero merged 1 commit into from
Oct 6, 2020
Merged

some connector test cleaned up. #1188

dero merged 1 commit into from
Oct 6, 2020

Conversation

@kidunot89
Copy link
Contributor

@kidunot89 kidunot89 commented Oct 5, 2020

Checklist

  • Suppress the database error printed to the console when edd_install() called.
  • Applies the $this->action_prefix to all test callback checks.
  • All short version arrays [] refactor to long version array() for consistency

@kidunot89 kidunot89 requested review from dero and kasparsd October 5, 2020 18:36
dero
dero approved these changes Oct 6, 2020
View reviewed changes
Copy link
Contributor

@dero dero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the improvements, @kidunot89!

@dero dero merged commit d8d529c into develop Oct 6, 2020
@dero dero deleted the tests/recent-test-cleanup-1 branch October 6, 2020 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kasparsd kasparsd Awaiting requested review from kasparsd

1 more reviewer

@dero dero dero approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kidunot89 @dero