Skip to content

Tests/user switching connector #1171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dero merged 2 commits into from
Oct 5, 2020
Merged

Tests/user switching connector #1171

dero merged 2 commits into from
Oct 5, 2020

Conversation

@kidunot89
Copy link
Contributor

@kidunot89 kidunot89 commented Sep 4, 2020

Partially fixes #1093 .

Summary checklist

  • switch_to_user callback tested and passing.
  • switch_back_user callback tested and passing.
  • switch_off_user and edited_term callbacks tested and passing.

@kidunot89 kidunot89 requested a review from kasparsd September 4, 2020 20:32
@kidunot89 kidunot89 self-assigned this Sep 4, 2020
dero
dero approved these changes Oct 5, 2020
View reviewed changes
Copy link
Contributor

@dero dero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dero dero merged commit 6718a99 into develop Oct 5, 2020
@dero dero deleted the tests/user-switching-connector branch October 5, 2020 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kasparsd kasparsd Awaiting requested review from kasparsd

1 more reviewer

@dero dero dero approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@kidunot89 kidunot89

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Improve Test Coverage

2 participants

@kidunot89 @dero