Skip to content

Conversation

@kidunot89
Copy link
Contributor

@kidunot89 kidunot89 commented Aug 20, 2020

Fixes #1044 .

Checklist

Adds a filter for modifying the WHERE statement and the records query.

@kidunot89 kidunot89 requested a review from kasparsd August 20, 2020 19:45
@kidunot89 kidunot89 self-assigned this Aug 20, 2020
@kidunot89 kidunot89 added the needs discussion The issue/PR needs further discussion before a solution can be implemented label Aug 20, 2020
Copy link
Contributor

@dero dero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kidunot89 Thanks. One question / suggestion.

@kidunot89 kidunot89 force-pushed the feature/stream-db-query-where-filter branch from 06d8ddf to 0d9bc09 Compare September 17, 2020 19:26
@kidunot89 kidunot89 requested a review from dero September 17, 2020 19:26
@kidunot89
Copy link
Contributor Author

@dero you're requested changes have been made. Please re-review.

Copy link
Contributor

@dero dero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now. Thanks!

@dero dero merged commit 5ed65e1 into develop Sep 23, 2020
@dero dero deleted the feature/stream-db-query-where-filter branch September 23, 2020 16:37
@kasparsd kasparsd mentioned this pull request Oct 14, 2020
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement needs discussion The issue/PR needs further discussion before a solution can be implemented

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add a filter to where db clause

2 participants