make sequence mandate plural elements if maxOccurs is present #82
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Details
Make sequence maxOccurs supported on a sequence element
Description
When maxOccurs is present on a sequence, the inner elements can be repeated, so they should be of plural type
Related Issue
Fixes half of #47
Motivation and Context
I had the occurrence of an .xsd with maxOccurs on a sequence on a spec
How Has This Been Tested
Implemented test cases, tried it at my own case, where it works too. Does not seem to change other test cases.
I'm not an expert in .xsd's and the workings of xgen, but i had the feeling, that a problem could occur, where nested sequence elements could be of different types (plural vs. singular) and i should have covered that in the code, but i'm not really sure how to write a test for it - suggestions welcome.
Types of changes
Checklist