Skip to content

Commit

Permalink
Update GitHub Action configurations (#26)
Browse files Browse the repository at this point in the history
- Update the Node.js version from 18 to 20 to resolve warning log in pipeline logs
- Add double quote for Go language test's coverprofile flag for avoid codov can't find "coverage.txt" in Windows environments
  • Loading branch information
zhangyimingdatiancai authored Jun 24, 2024
1 parent 413e1f1 commit c0e4e0c
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 6 deletions.
6 changes: 3 additions & 3 deletions .github/workflows/go.yml
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ jobs:
- name: Test
run: |
cd cmd
GOOS=js GOARCH=wasm GO111MODULE=on go test -exec="$(go env GOROOT)/misc/wasm/go_js_wasm_exec" -v ./... -coverprofile=coverage.txt -covermode=atomic
GOOS=js GOARCH=wasm GO111MODULE=on go test -exec="$(go env GOROOT)/misc/wasm/go_js_wasm_exec" -v ./... -coverprofile="coverage.txt" -covermode=atomic
- name: Codecov
uses: codecov/codecov-action@v4
Expand All @@ -58,9 +58,9 @@ jobs:
gzip -f --best ../dist/excelize.wasm
- name: Setup Node.js
uses: actions/setup-node@v3
uses: actions/setup-node@v4
with:
node-version: 18
node-version: 20

- name: NPM Build
run: |
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/publish.yml
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ jobs:
- name: Test
run: |
cd cmd
GOOS=js GOARCH=wasm GO111MODULE=on go test -exec="$(go env GOROOT)/misc/wasm/go_js_wasm_exec" -v ./... -coverprofile=coverage.txt -covermode=atomic
GOOS=js GOARCH=wasm GO111MODULE=on go test -exec="$(go env GOROOT)/misc/wasm/go_js_wasm_exec" -v ./... -coverprofile="coverage.txt" -covermode=atomic
- name: Codecov
uses: codecov/codecov-action@v4
Expand All @@ -53,9 +53,9 @@ jobs:
gzip -f --best ../dist/excelize.wasm
- name: Setup Node.js
uses: actions/setup-node@v3
uses: actions/setup-node@v4
with:
node-version: 18
node-version: 20

- name: NPM Build
run: |
Expand Down

0 comments on commit c0e4e0c

Please sign in to comment.