test: pass data into napi_create_external

Since v8 10.1 v8::External::New DCHECKs that the data passed into it cannot be a nullptr because that's not serializable as external references. This updates the test to pass a dummy data pointer to the call - which does not matter for the test since we only care about whether the finalizer is called. Refs: https://chromium-review.googlesource.com/c/v8/v8/+/3513234 PR-URL: nodejs#42532 Refs: nodejs#42115 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
xtx1130 · Apr 25, 2022 · 9158815 · 9158815
1 parent ebefeb8
commit 9158815
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/test/js-native-api/test_exception/test_exception.c b/test/js-native-api/test_exception/test_exception.c
@@ -2,6 +2,7 @@
 #include "../common.h"
 
 static bool exceptionWasPending = false;
+static int num = 0x23432;
 
 static napi_value returnException(napi_env env, napi_callback_info info) {
   size_t argc = 1;
@@ -83,7 +84,7 @@ static napi_value createExternal(napi_env env, napi_callback_info info) {
   napi_value external;
 
   NODE_API_CALL(env,
-      napi_create_external(env, NULL, finalizer, NULL, &external));
+      napi_create_external(env, &num, finalizer, NULL, &external));
 
   return external;
 }