-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for ESM via esbuild #5092
Conversation
These are for integration tests which need tsc sources anyway
Latest runs integration test off esbuild output 🎉 |
Ready to merge, this is much less risky then initially as the old tsc-based webpacked output is still shipped, just the ESM output is based on esbuild. |
@Tyriar Wow, this looks like some heavy lifting to get ESM rolling, thx for doing the nasty works! 🚀 This diagram looks important to me - should we link that under the wiki build page? Also to make sense for me - does that mean, that internally all packages are still handled by UMD, but the final packages for delivery are ESM now? Or do we ship now UMD and ESM in the final packages? |
@jerch yeah it was a bit rough, but a lot of this felt necessary in order to bring the nice scroll bars over.
Good idea, I'll clean up the diagram and stick it in contributing.md and/or the wiki.
We ship both which is possible by using the I wanted |
Did a full rewrite of the contributing page https://github.com/xtermjs/xterm.js/wiki/Contributing and added image source to the repo in #5094 |
This PR includes the esbuild-related parts from #5077
This is roughly how the dependencies work currently:
The big wins here are:
module
properly andlib/xterm.mjs
(ES6 module no export Terminal #2878), vscode does not use this yet but will soon hopefully (Explore AMD to ESM migration microsoft/vscode#160416)