Add sanity check in AccessibilityManager #2085
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jerch it's not just t0001 that fails, it's only the first test as I tried disabling it and the second test failed. |
|
Maybe the container disk access sucks, moving it out passed (for the first time) |
Tyriar
added a commit
to microsoft/xterm.js
that referenced
this pull request
May 21, 2019
Merge pull request xtermjs#2081 from Tyriar/xterm-tests Merge pull request xtermjs#2085 from Tyriar/a11y_fix Merge pull request xtermjs#2088 from Tyriar/fix_coveralls Merge pull request xtermjs#2092 from Tyriar/layering Merge pull request xtermjs#2094 from Tyriar/2005_colormanager Merge pull request xtermjs#2096 from Tyriar/render_coordinator Merge pull request xtermjs#2098 from Tyriar/2093_logo_demo Merge pull request xtermjs#2100 from Tyriar/2099_pausing Merge pull request xtermjs#2101 from Tyriar/bad_comment_ Merge pull request xtermjs#2109 from Tyriar/2107_cursor_report Merge pull request xtermjs#2113 from Tyriar/2111_automate_patch_release Merge pull request xtermjs#2110 from Tyriar/split_out_integration Merge pull request xtermjs#2114 from Tyriar/consolidate_api_test_timeout Diff: xtermjs/xterm.js@2d59185...93c1b89
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2082
I couldn't reproduce or see why this could happen, so let's just add this sanity check.