getCoordsRelativeToElement: use getBoundingClientRect and clientX/Y. - #1788
Merged
Merged
Conversation
Tyriar
approved these changes
Dec 9, 2018
Member
|
@mofux would appreciate a review on this when you get a chance, it's scary changing old code like this 😄 |
mofux
approved these changes
Dec 9, 2018
mofux
left a comment
mofux
left a comment
Contributor
There was a problem hiding this comment.
I can confirm it's working for static, absolute and fixed positioned elements 👍The code is also a good improvement to what was in place before 😅
Contributor
|
@Tyriar Please feel free to merge. |
Member
|
Thanks for the PR @gou4shi1, it's much better than it was 👍 |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#1684