Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable strict null checks and no DOM access in common and core #1699

Merged
merged 10 commits into from
Oct 5, 2018
Merged

Enable strict null checks and no DOM access in common and core #1699

merged 10 commits into from
Oct 5, 2018

Conversation

Tyriar
Copy link
Member

@Tyriar Tyriar commented Sep 17, 2018 •
edited
Loading

Part of #1507
Part of #1319

This change enables strict mode and prevents DOM access in ./src/common and ./src/core by adding a noEmit tsconfig.json that gets built as the pretest npm script task. 🍾

@Tyriar Tyriar added this to the 3.8.0 milestone Sep 17, 2018
@Tyriar Tyriar self-assigned this Sep 17, 2018
@Tyriar Tyriar force-pushed the common_layering_strict branch from 8ec0a08 to a7a58aa Compare September 17, 2018 20:44
@Tyriar Tyriar changed the title Enable strict null checks and no DOM access in common Enable strict null checks and no DOM access in common and core Sep 18, 2018
@mofux
Copy link
Contributor

mofux commented Oct 2, 2018

Haven't tested, but LGTM in general 👍

@Tyriar Tyriar modified the milestones: 3.8.0, 3.9.0 Oct 2, 2018
@Tyriar Tyriar merged commit b85b9bb into xtermjs:master Oct 5, 2018
@Tyriar Tyriar deleted the common_layering_strict branch October 5, 2018 16:36
@Tyriar Tyriar mentioned this pull request Dec 11, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Tyriar Tyriar

Labels
None yet
Projects
None yet
Milestone
3.9.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Tyriar @mofux