Remove StaticCharAtlas support (fixes #1576) #1580
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This defaults to the dynamic atlas and leaves in
NoneCharAtlas
and theexperimentalCharAtlas
option (with'static'
removed).This leaves me with a few questions:
Do we want to completely remove support for
NoneCharAtlas
andexperimentalCharAtlas
?NoneCharAtlas
provides a nice example of the modularity of the atlas system, even though it doesn't make much sense to use.If we want remove the
experimentalCharAtlas
option, should we leave the typedef there (ignoring any values passed) for backwards compatibility? I think semver requires this, though it's not a runtime concern.If we want to keep
experimentalCharAtlas
, should we rename it tocharAtlas
? What should we do if someone passes in anexperimentalCharAtlas
option? Should we leave'static'
in there as an alias to'dynamic'
for compatibility? I think semver requires this.Unfortunately I don't think we have any established standard for warning about deprecated features. Is it appropriate to use
console.warn
in a library context like this? My guess is no.