Remove StaticCharAtlas support (fixes #1576) #1580
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This defaults to the dynamic atlas and leaves in NoneCharAtlas and the experimentalCharAtlas option (with 'static' removed). This leaves me with a few questions: 1. Do we want to completely remove support for NoneCharAtlas and experimentalCharAtlas? NoneCharAtlas provides a nice example of the modularity of the atlas system, even though it doesn't make much sense to use. 2. If we want remove the experimentalCharAtlas option, should we leave the typedef there (ignoring any values passed) for backwards compatibility? I think semver requires this, though it's not a runtime concern. 3. If we want to keep experimentalCharAtlas, should we rename it to charAtlas? What should we do if someone passes in an experimentalCharAtlas option? Should we leave 'static' in there as an alias to 'dynamic' for compatibility? I think semver requires this. 4. Unfortunately I don't think we have any established standard for warning about deprecated features. Is it appropriate to use `console.warn` in a library context like this? My guess is no.
|
Tyriar
reviewed
Jul 24, 2018
|
|
||
| declare const Promise: any; | ||
|
|
||
| export interface IOffscreenCanvas { |
There was a problem hiding this comment.
👍 to removing this, the shared/ idea has been replaced with #1507
Adding to the readme about experimental API as I think that was either just in my head or in various release notes 😄 #1581 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This defaults to the dynamic atlas and leaves in
NoneCharAtlasand theexperimentalCharAtlasoption (with'static'removed).This leaves me with a few questions:
Do we want to completely remove support for
NoneCharAtlasandexperimentalCharAtlas?NoneCharAtlasprovides a nice example of the modularity of the atlas system, even though it doesn't make much sense to use.If we want remove the
experimentalCharAtlasoption, should we leave the typedef there (ignoring any values passed) for backwards compatibility? I think semver requires this, though it's not a runtime concern.If we want to keep
experimentalCharAtlas, should we rename it tocharAtlas? What should we do if someone passes in anexperimentalCharAtlasoption? Should we leave'static'in there as an alias to'dynamic'for compatibility? I think semver requires this.Unfortunately I don't think we have any established standard for warning about deprecated features. Is it appropriate to use
console.warnin a library context like this? My guess is no.