Start of improved layering #1508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can we safely merge this without breaking compatibility of the 3.x releases, or should this be targeted towards a 4.0 release? I'm a bit afraid the changes in this PR become stale if this hangs around for too long. I think as long as we maintain compatibility with the public 3.x api it should be okay to merge, no? |
|
I think this maintains the public API fine. It will break VS Code for example but that's because I'll polish it up now as merging this will really help with pulling components into their correct spots. |
|
Ok I think it's ready for proper review(s) |
|
Still a long way to go, but it's a good start 😅Tested locally and works fine 👍 |
|
Works in VS Code so merging in |
Kya123iu
approved these changes
Oct 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Curious what people think of this change, I haven't gone and done a polish pass on this yet but the basic structure I think we should start with when considering #1507 is there.
IKeyboardEventincommoncore/input/Keyboard.tsand added some testspublicwhich is the new API. This will allow us to make changes to./src/Terminaland eventually move it intocore. This will break any integrations that access private API (which we don't guarantee).