Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proposal: Remove 'open' event #901

Closed
Tyriar opened this issue Aug 19, 2017 · 0 comments
Closed

Proposal: Remove 'open' event #901

Tyriar opened this issue Aug 19, 2017 · 0 comments
Labels
breaking-change Breaks API and requires a major version bump type/proposal A proposal that needs some discussion before proceeding
Milestone
3.0.0

Comments

@Tyriar
Copy link
Member

Tyriar commented Aug 19, 2017

The Terminal.open call is synchronous so the open event seems a bit useless.
@Tyriar Tyriar added breaking-change Breaks API and requires a major version bump type/proposal A proposal that needs some discussion before proceeding labels Aug 19, 2017
@Tyriar Tyriar added this to the 3.0.0 milestone Aug 19, 2017
@Tyriar Tyriar changed the title Proposal: Deprecate 'open' event Proposal: Remove 'open' event Aug 19, 2017
Tyriar added a commit to Tyriar/xterm.js that referenced this issue Aug 19, 2017
@Tyriar
Remove open event
e848d6a 
Fixes xtermjs#901
@Tyriar Tyriar mentioned this issue Aug 20, 2017
Merged
9 tasks
@Tyriar Tyriar closed this as completed Aug 20, 2017
@Tyriar Tyriar mentioned this issue Dec 11, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking-change Breaks API and requires a major version bump type/proposal A proposal that needs some discussion before proceeding
Projects
None yet
Milestone
3.0.0
Development

No branches or pull requests
1 participant
@Tyriar