Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop focusing automatically when opening the terminal in a DOM node #646

Closed
parisk opened this issue Apr 30, 2017 · 2 comments
Closed

Stop focusing automatically when opening the terminal in a DOM node #646

parisk opened this issue Apr 30, 2017 · 2 comments
Assignees
@Tyriar
Labels
breaking-change Breaks API and requires a major version bump type/enhancement Features or improvements to existing features
Milestone
3.0.0

Comments

@parisk
Copy link
Contributor

parisk commented Apr 30, 2017

When using open to expose an xterm.js terminal in the DOM, the terminal gets focus automatically.

This may be useful for very simple use cases (like the demo of xterm.js), but it can make it difficult for more complex applications to control where the focus is.

The best thing to do here is stop focusing on the terminal inside open and let the user decide when to focus.

Initiated from #640.
@parisk parisk added the feature label Apr 30, 2017
@parisk parisk added this to the 3.0.0 milestone Apr 30, 2017
@parisk parisk mentioned this issue Aug 3, 2017
Closed
13 tasks
Tyriar added a commit to Tyriar/xterm.js that referenced this issue Aug 7, 2017
@Tyriar
No longer focus the terminal by default
b1c6a97 
Fixes xtermjs#646
@Tyriar Tyriar mentioned this issue Aug 7, 2017
Merged
@Tyriar Tyriar self-assigned this Aug 7, 2017
@Tyriar Tyriar added the breaking-change Breaks API and requires a major version bump label Aug 8, 2017
@Tyriar Tyriar closed this as completed Aug 17, 2017
@Tyriar Tyriar mentioned this issue Aug 17, 2017
Closed
Tyriar added a commit to Tyriar/hyper that referenced this issue Dec 11, 2017
@Tyriar
Remove second open arg
9765c3c 
This was removed in xterm@3, see xtermjs/xterm.js#646
@Tyriar Tyriar mentioned this issue Dec 11, 2017
Merged
ppot pushed a commit to vercel/hyper that referenced this issue Dec 11, 2017
@Tyriar @ppot
Remove second open arg (#2544)
4218473 
This was removed in xterm@3, see xtermjs/xterm.js#646
@Tyriar Tyriar added type/enhancement Features or improvements to existing features and removed type/feature labels Apr 4, 2018
@manoletto
Copy link

Ok, but how to set focus so,
and make the cursor appear ?!

@totomz
Copy link

totomz commented Apr 8, 2020 •
edited
Loading

@manoletto I guess we have to explicitly call term.focus()

focus() in the docs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Tyriar Tyriar

Labels
breaking-change Breaks API and requires a major version bump type/enhancement Features or improvements to existing features
Projects
None yet
Milestone
3.0.0
Development

No branches or pull requests
4 participants
@parisk @Tyriar @totomz @manoletto