-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing CSS file in npm package #414
Comments
I am happy to submit a PR with a script that copies the file over before publishing: cf https://github.com/jupyterlab/jupyterlab/blob/bda6c803494a0e6ddf5df673749be5a9590bf719/scripts/copyfiles.js |
The copy is meant to be done here https://github.com/sourcelair/xterm.js/blob/master/bin/build#L29, maybe it's not being published due to |
It must only include JS files by default: https://github.com/jupyterlab/jupyterlab/blob/bda6c803494a0e6ddf5df673749be5a9590bf719/package.json#L97 |
On it. |
@Tyriar and @blink1073 feel free to take a look at #416. I will merge ASAP. |
Should be fine with |
The copy script still didn't do the trick, because the release has the CSS in the |
Current release (2.2.2) does not include the
src/xterm.css
file.The text was updated successfully, but these errors were encountered: