Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ligatures not working with webgl renderer #3094

Closed
UziTech opened this issue Sep 14, 2020 · 2 comments · Fixed by #3286
Closed

Ligatures not working with webgl renderer #3094

UziTech opened this issue Sep 14, 2020 · 2 comments · Fixed by #3286
Assignees
@Tyriar
Labels
area/addon/ligatures area/addon/webgl type/bug Something is misbehaving
Milestone
4.12.0

Comments

@UziTech
Copy link
Contributor

UziTech commented Sep 14, 2020

The Ligatures addon doesn't do anything when using the WebGl addon

Details

  • Browser and browser version: Electron 6
  • OS version: Windows
  • xterm.js version:
    • xterm 4.9.0
    • webgl 0.9.0
    • ligatures 0.3.0
This was referenced Sep 15, 2020
Merged
Merged
@UziTech
Copy link
Contributor Author

UziTech commented Oct 9, 2020

@Tyriar did this issue slip through? Can this issue get triaged?

@Tyriar
Copy link
Member

Tyriar commented Nov 4, 2020

@UziTech sorry about that, I was on leave for a few weeks and am only just almost caught up now 🙂

@Tyriar Tyriar mentioned this issue Apr 2, 2021
Closed
Tyriar added a commit to Tyriar/xterm.js that referenced this issue Apr 2, 2021
@Tyriar
Convert CharacterJoinerRegistry to a service
999116c 
Part of xtermjs#3094, xtermjs#3283
This was referenced Apr 2, 2021
Merged
Open
@Tyriar Tyriar added this to the 4.12.0 milestone Apr 2, 2021
Tyriar added a commit to Tyriar/xterm.js that referenced this issue Apr 2, 2021
@Tyriar
Webgl ligature support
b03a25f 
Fixes xtermjs#3094
@Tyriar Tyriar self-assigned this Apr 2, 2021
@Tyriar Tyriar mentioned this issue Apr 2, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Tyriar Tyriar

Labels
area/addon/ligatures area/addon/webgl type/bug Something is misbehaving
Projects
None yet
Milestone
4.12.0
Development

Successfully merging a pull request may close this issue.

Webgl ligature support Tyriar/xterm.js
2 participants
@UziTech @Tyriar