Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace ISelectionPosition API with IBufferRange #2480

Closed
Tyriar opened this issue Oct 17, 2019 · 3 comments
Closed

Replace ISelectionPosition API with IBufferRange #2480

Tyriar opened this issue Oct 17, 2019 · 3 comments
Labels
area/api type/debt Technical debt that could slow us down in the long run
Milestone

Comments

@Tyriar
Copy link
Member

Tyriar commented Oct 17, 2019

This will allow us to have generic interfaces to represent a buffer range vs a viewport range

interface IBufferRange {
  start: IBufferCellPosition;
  end: IBufferCellPosition;
}
interface IBufferPosition {
  x: number;
  y: number;
}

More context: #2470

@Tyriar Tyriar added type/debt Technical debt that could slow us down in the long run area/api labels Oct 17, 2019
@Tyriar Tyriar added this to the 5.0.0 milestone Oct 17, 2019
@Tyriar
Copy link
Member Author

Tyriar commented Oct 23, 2019

Thought: this position is only valid immediately after it was generated, y would need to be a marker for any longer.

@jerch
Copy link
Member

jerch commented Oct 24, 2019

Thought: this position is only valid immediately after it was generated, y would need to be a marker for any longer.

Certainly a problem - could we get this done with markers? Not sure about their maintenance/update penalty, if there are a few held...

@Tyriar
Copy link
Member Author

Tyriar commented Oct 25, 2019

Should be fine if there aren't that many, marker have overhead of initializing an object and having their line updated on every scroll once scrollback is maxed out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/api type/debt Technical debt that could slow us down in the long run
Projects
None yet
Development

No branches or pull requests

2 participants