Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WebGL Renderer #2033

Closed
Tyriar opened this issue Apr 29, 2019 · 4 comments · Fixed by #3273
Closed

WebGL Renderer #2033

Tyriar opened this issue Apr 29, 2019 · 4 comments · Fixed by #3273
Assignees
@Tyriar
Labels
area/addon/webgl type/enhancement Features or improvements to existing features
Milestone
4.12.0

Comments

@Tyriar
Copy link
Member

Tyriar commented Apr 29, 2019 •
edited
Loading

WIP: #1790
@Tyriar Tyriar added type/enhancement Features or improvements to existing features area/renderer labels Apr 29, 2019
@Tyriar Tyriar self-assigned this Apr 29, 2019
@Tyriar Tyriar mentioned this issue Apr 29, 2019
Closed
@Tyriar
Copy link
Member Author

Tyriar commented Jun 13, 2019

Update: #1790 (comment)

@Tyriar
Copy link
Member Author

Tyriar commented Jun 17, 2019

This might workaround these weird issues with canvas that pop up on some Electron updates as we're talking more directly to the GPU microsoft/vscode#75634

@Tyriar Tyriar mentioned this issue Oct 10, 2019
Closed
@Tyriar Tyriar mentioned this issue Oct 17, 2019
Closed
@chucknelson
Copy link

@Tyriar - Came across this reading about the VS Code webgl renderer, and this can be closed, right? WebGL renderer PR (#1790) is merged and it's had quite a few version released so far, right?

@Tyriar
Copy link
Member Author

Tyriar commented Sep 2, 2020

Let's keep it open until the experimental note is removed from https://github.com/xtermjs/xterm.js/blob/master/addons/xterm-addon-webgl/README.md, there's still a few lingering issues https://github.com/xtermjs/xterm.js/issues?q=is%3Aopen+is%3Aissue+label%3Aarea%2Faddon%2Fwebgl

Tyriar added a commit to Tyriar/xterm.js that referenced this issue Mar 30, 2021
@Tyriar
Remove experimental note from webgl renderer
dafe7ea 
Fixes xtermjs#2033
@Tyriar Tyriar added this to the 4.12.0 milestone Mar 30, 2021
@Tyriar Tyriar mentioned this issue Mar 30, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Tyriar Tyriar

Labels
area/addon/webgl type/enhancement Features or improvements to existing features
Projects
None yet
Milestone
4.12.0
Development

Successfully merging a pull request may close this issue.

Remove experimental note from webgl renderer Tyriar/xterm.js
2 participants
@chucknelson @Tyriar