Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Links are sometimes not activated until scroll #1233

Closed
Tyriar opened this issue Jan 22, 2018 · 0 comments
Closed

Links are sometimes not activated until scroll #1233

Tyriar opened this issue Jan 22, 2018 · 0 comments
Assignees
@Tyriar
Labels
type/bug Something is misbehaving
Milestone
3.1.0

Comments

@Tyriar
Copy link
Member

Tyriar commented Jan 22, 2018

microsoft/vscode#36072
@Tyriar Tyriar added the type/bug Something is misbehaving label Jan 22, 2018
@Tyriar Tyriar added this to the 3.1.0 milestone Jan 22, 2018
@Tyriar Tyriar self-assigned this Jan 22, 2018
Tyriar added a commit to Tyriar/xterm.js that referenced this issue Jan 22, 2018
@Tyriar
Use explicit null check to ensure start/end row is valid
16abf71 
It looks like this could have caused the inconsistent behavior with
links not activating and then working again after scrolling

Fixes xtermjs#1233
@Tyriar Tyriar mentioned this issue Jan 22, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Tyriar Tyriar

Labels
type/bug Something is misbehaving
Projects
None yet
Milestone
3.1.0
Development

No branches or pull requests
1 participant
@Tyriar