Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix image generation in OpenaiChat #2390

Merged
merged 2 commits into from
Nov 20, 2024
Merged

Fix image generation in OpenaiChat #2390

merged 2 commits into from
Nov 20, 2024

Conversation

hlohaus
Copy link
Collaborator

@hlohaus hlohaus commented Nov 20, 2024

No description provided.

Copy link

Pull Request Review

Author: H Lohaus

Title: Fix image generation in OpenaiChat

Thank you for contributing to the project! Your changes to the OpenaiChat provider look great and seem to address the image generation functionality effectively.

Summary of Changes:

  • Added image_models to the class, which uses the existing fallback_models.
  • Modified the create_async_generator method to set history_disabled to False by default.
  • Removed unnecessary WebSocket handling code that was commented out.
  • Improved the handling of image generation within the iter_messages_line method, ensuring that images are processed correctly when received.

Review Comments:

  • The addition of image_models is a good enhancement, as it clarifies the purpose of the models being used.
  • Setting history_disabled to False by default may improve user experience, but please ensure this aligns with the intended functionality.
  • The removal of the commented-out WebSocket code helps clean up the codebase, making it easier to read and maintain.
  • The changes in iter_messages_line enhance the handling of multimodal responses, which is crucial for image generation.

Overall, the modifications are well-structured and improve the functionality of the OpenaiChat provider.

Please let me know if you need any further feedback or assistance!

Best regards,
[Your Name]

@hlohaus hlohaus merged commit dba41cd into xtekky:main Nov 20, 2024
1 check passed
hqnicolas added a commit to hqnicolas/continue4free that referenced this pull request Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant