Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix aliases to gui arguments #2382

Merged
merged 1 commit into from
Nov 19, 2024
Merged

Fix aliases to gui arguments #2382

merged 1 commit into from
Nov 19, 2024

Conversation

hlohaus
Copy link
Collaborator

@hlohaus hlohaus commented Nov 19, 2024

No description provided.

@hlohaus hlohaus merged commit 3aa497f into xtekky:main Nov 19, 2024
1 check passed
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Review

Author: H Lohaus

Title: Fix aliases to gui arguments

Thank you for contributing to the project! Your changes to the gui_parser.py file improve the way command-line arguments are handled by consolidating the argument aliases. This makes the code cleaner and more intuitive for users.

Summary of Changes

  • Removed the use of add_argument_alias and replaced it with a more straightforward approach by combining the short and long options directly in the add_argument method.

Suggested Improvements

  • Consider adding a brief description in the pull request description to provide context for your changes. This helps reviewers understand the motivation behind the modifications.

Overall, great work on this pull request! It looks good to me.

Best,
[Your Name]

g4f/gui/gui_parser.py Show resolved Hide resolved
g4f/gui/gui_parser.py Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant