forked from facebook/create-react-app
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wizard to 3.0.1 #28
Merged
Merged
Wizard to 3.0.1 #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Rename production configuration * Upgrade lint staged * Merge mode, bail, devtool, and entry * Merge output settings * Remove old comment * Merge some trivial differences * Disable minimize in development mode * Only minify html and generate SW in production * Adjust comment * Toggle development plugins * Add missing imports * Scope settings * Delete development config * Use new config file * Remove unnecessary config import
* Suggest Encore when not building a SPA with Symfony * Update README.md
* add pr badge 🎉 * add rounded badge 💥 * Update README.md
Reduce two-step install to just one step (per the latest storybook docs) Change (i) `npm install -g @storybook/cli` and (ii) `sb init` to `npx -p @storybook/cli sb init` Refs: https://storybook.js.org/basics/quick-start-guide/
* extra polyfills must be included manually, fixes facebook#5795 * make note italicized
Create React Native App (https://github.com/react-community/create-react-native-app ) has been archived by the owner. It is now read-only.
) * update named-asset-import babel plugin * add tests to named-asset-import plugin * add more plugin test * extract generateNewSource method, renaming variables * extract replaceNotVisitedSpecifiers for export and import visitors * remove visited list update from importDeclaration * renaming methods and removing return directly instead of saving
* Add allowESModules option to babel-preset-react-app * changes after feedback * Apply suggestions from code review Co-Authored-By: Pajn <[email protected]>
This allows us to leave the import in the code, and webpack will still tree shake it out
* Fix TypeScript decorator support * Update babel flow override * WIP
* Grammar fixes 1- For `Here's a `: The singular verb form ’s does not seem to agree with the plural subject a few common cases where you might want to try something else. Consider changing the verb form. 2- Added `A` before Reasonably : The noun phrase Reasonably good configuration seems to be missing a determiner before it. Consider adding an article. An article (a, an, or the) is a type of determiner. Possessive adjectives (my, his, our), possessive nouns (Joe’s, mother’s), and quantifiers (each, every) are also determiners. Single countable nouns usually require a determiner. * Update README.md
* Disable copy to clipboard in cra --info Fixes an issue where npx create-react-app --info throws an exception on Windows. The exception was caused by envinfo's copy to clipboard functionality; envinfo is distributed pre-bundled, but the dependency it uses for copying to the clipboard makes use of a binary on Windows that can't be found once the bundle is made. Disabling copy to clipboard fixes the issue. Closes facebook#5757. * Explicitly set clipboard to false
* Add placeholders to template README for bit.ly links. * Add placeholders to template README for goo.gl links.
* remove padding 0 on body from default styles * Update index.css
Typo : preache => precache
Fix copy
…6876) * Change cssmodule classname hash to use repo relative paths instead of system absolute paths
* Update dependencies preset to support browserslist * Loose mode array destructuring for hooks in dependencies
* Need to install graphql package * Need to provide real graphql in the .graphql file, not gql wrapped graphql
…f CRA (facebook#6945) Added block quote with warning about issues when CRA is installed globally.
* Adds the configuration for PnP/Typescript * Adds the header * Bumps ts-pnp * Bumps fork-ts-checker-webpack-plugin
…#6979) * Add note to restart the dev server after change .env file * Update copy Co-authored-by: Ian Sutherland <[email protected]>
* Temporary fix for babel-jest preflight error * Update babel-jest in react-error-overlay
This reverts commit e5f69b5.
[email protected] # Conflicts: # packages/eslint-config-react-app/index.js # packages/eslint-config-react-app/package.json # packages/react-app-polyfill/package.json # packages/react-scripts/config/webpack.config.dev.js # packages/react-scripts/config/webpack.config.prod.js # packages/react-scripts/package.json # packages/react-scripts/scripts/utils/createJestConfig.js
fezhengjin
approved these changes
May 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Steps