Added scrolling functionality #19
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Except "magic number" 3 in `pos` variable
Even it's cleaner… it could interfere with other patches.
|
Hey, now it's better? ;) |
|
@morsik thanks for refreshing your changes but it doesn't apply to master, you have to rebase and while at it squash all commits together. You can clean whitespace if you want but do it in a different commit than the one adding the scrolling please. |
|
@morsik could you please check that my pull19 branch works as expected? |
|
Yeah, looks like works correctly. |
|
@morsik thanks for checking, will remove pgup / pgdown then since they don't work here either. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scrolling works with
n(page up) andm(page down) keys.Should works with PgUp/PgDn too (as it's coded?), but for some unknown reason for me — it doesn't ;(