게시물, 댓글 고유 링크에 mid를 포함하도록 수정 #2168
Merged
+15
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjrambo
reviewed
Oct 18, 2017
| */ | ||
| function getCommentMid() | ||
| { | ||
| $model = getModel('module'); |
There was a problem hiding this comment.
$model 이렇게 적으면 어떤 모델을 불러오는지 명확한 네이밍이 아닌것 같습니다.
정확하게 $oModuleModel = (ObjectModuleModel) 으로 명확한 이름이 나오도록 하는것이 좋겠습니다.
아래의 $module 이라는 이름도 역시 마찬가지로 $moduleInfo 혹은 $module_info 으로 명확하게...
There was a problem hiding this comment.
지적 감사합니다. 알려주신대로 수정해서 놓겠습니다.
ghost
self-assigned this
ghost
merged commit
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2155 이슈를 수정한 PR입니다.
Content 위젯과 RSS 모듈에서 mid를 포함한 링크가 걸려있는 지 확인해보았습니다.
빠진 곳 있으면 알려주세요.