Partial blocks and inline partials by thekid · Pull Request #9 · xp-forge/handlebars

thekid · 2017-09-17T10:02:31Z

Reading https://cloudfour.com/thinks/the-hidden-power-of-handlebars-partials/ motivated me to implement partial blocks and inline partials.

page.handlebars

{{#> layout}}
  {{#*inline "nav"}}
    My Nav
  {{/inline}}
  {{#*inline "content"}}
    My Content
  {{/inline}}
{{/layout}}

layout.handlebars

<div class="nav">
  {{> nav}}
</div>
<div class="content">
  {{> content}}
</div>

See also http://handlebarsjs.com/partials.html and handlebars-lang/handlebars.js#1082

thekid · 2017-09-17T10:06:50Z

src/main/php/com/handlebarsjs/PartialBlockHelper.class.php

+    try {
+      $templates->register('@partial-block', $this->fn);
+      return $context->engine->transform($this->name, $context, $this->start, $this->end, '');
+    } catch (TemplateNotFoundException $e) {


It would be nicer if mustache template loaders would either:

have a provides() method to test for template existance, or

accept a default closure to execute if the template does not exist

Catching an exception for control flow does not feel right [TM]

See xp-forge/mustache#8

Instead of throwing an exception when load() is called, an Input instance is returned. Its exists() method can be used to test whether the loaded template exists. See xp-forge/handlebars#9 (review)

…er API

thekid

The Templates class needs some more tests

thekid · 2017-09-17T15:45:43Z

src/main/php/com/handlebarsjs/Templates.class.php

+
+  /** @return com.github.mustache.TemplateListing */
+  public function listing() {
+    return $this->delegate->listing();


This is not correct, the listing is missing the templates registered in $this->templates; also, it fails if $this->delegate is null.

thekid · 2017-09-17T15:46:27Z

src/main/php/com/handlebarsjs/Templates.class.php

+   */
+  public function register($name, $content) {
+    $previous= isset($this->templates[$name]) ? $this->templates[$name] : null;
+    if ($content instanceof Node) {


This branch is not tested

See #9 (comment)

thekid · 2017-09-17T16:19:00Z

src/main/php/com/handlebarsjs/BlockHelpers.class.php

    self::$byName['with']= XPClass::forName('com.handlebarsjs.WithBlockHelper');
    self::$byName['each']= XPClass::forName('com.handlebarsjs.EachBlockHelper');
+    self::$byName['>']= XPClass::forName('com.handlebarsjs.PartialBlockHelper');
+    self::$byName['*inline']= XPClass::forName('com.handlebarsjs.InlinePartialHelper');


This pull request does not support generic decorators as e.g.

{{#grid data}} {{#*column "Column 1"}}{{foo}}{{/column}} {{#*column "Column 2"}}{{bar}}{{/column}} {{/grid}}

...just *inline as a special case! This is the same as the original implementation in handlebars-java

See https://cloudfour.com/thinks/the-hidden-power-of-handlebars-partials/

thekid · 2017-09-17T19:21:28Z

src/main/php/com/handlebarsjs/PartialBlockHelper.class.php

+
+    $source= $templates->source($this->name);
+    if ($source->exists()) {
+      $previous= $templates->register('@partial-block', $block);


Unsure about correct context here, need some more tests...

See handlebars-lang/handlebars.js#1099

See handlebars-lang/handlebars.js#1290

Based on https://github.com/wycats/handlebars.js/blob/master/docs/decorators-api.md

thekid

Decorators aren't 100% correct yet

thekid · 2017-09-17T23:18:49Z

src/main/php/com/handlebarsjs/PartialBlockHelper.class.php

+    $source= $templates->source($this->name);
+    if ($source->exists()) {
+      $this->fn->enter($context);
+      $previous= $templates->register('@partial-block', $this->fn);


This will re-run the decorators unnecessarily...

thekid added 6 commits September 17, 2017 11:38

Initial release: Partial block helper

890f1c6

Replace template loader with implementation supporting @partial-block

5d9d96b

Add partial block helper

db97d3d

Add possibility to test with templates

413ca52

Add test for parsing partial blocks

bf1726b

Initial support for inline partials

46df23d

thekid added the enhancement label Sep 17, 2017

Fix return

9cff7f3

thekid commented Sep 17, 2017

View reviewed changes

thekid added 2 commits September 17, 2017 12:08

QA: Add missing apidocs

0c4c560

Add tests for Templates class

034b6af

thekid mentioned this pull request Sep 17, 2017

Refactor template loading mechanism xp-forge/mustache#8

Merged

Upgrade to xp-forge/mustache v5.1.0 and make use of new template load…

d41ff92

…er API

thekid commented Sep 17, 2017

View reviewed changes

thekid mentioned this pull request Sep 17, 2017

Port handlebars-layouts #7

Closed

thekid added 2 commits September 17, 2017 17:50

Test node handling

9f6a63d

See #9 (comment)

Fix listing()

377aba7

thekid commented Sep 17, 2017

View reviewed changes

thekid added 5 commits September 17, 2017 18:38

Add link to handlebars spec

f11dd79

Fix register() not working with Source instances

b662f32

Eagerly evaluate partial blocks, so nested inline partials get evaluated

6e88762

See https://cloudfour.com/thinks/the-hidden-power-of-handlebars-partials/

Extend com.handlebarsjs.unittest.PartialBlockHelperTest::layout() test

7e7f438

Only evaluate @partial-block once

1ef5167

thekid commented Sep 17, 2017

View reviewed changes

thekid added 3 commits September 17, 2017 22:05

Add tests for nested partial blocks

8d23ec6

See handlebars-lang/handlebars.js#1099

Fix partial blocks within each

29517dd

See handlebars-lang/handlebars.js#1290

Add tests for contexts

37ea0db

thekid changed the title ~~Partial blocks~~ Partial blocks and inline partials Sep 17, 2017

Refactor and support decorators

5310886

Based on https://github.com/wycats/handlebars.js/blob/master/docs/decorators-api.md

thekid added 6 commits September 18, 2017 00:58

Add Decoration class

3136259

QA: Shorten invocation code

27a7539

Rename decorators() -> enter()

5e43601

Document Decorators

16a0ed6

Speed up decorator name lookup

da39668

Rename evaluate() -> enter()

e292e24

thekid commented Sep 17, 2017

View reviewed changes

Do not run decorators twice

fd5efef

thekid merged commit ffdd64b into master Nov 26, 2017

thekid deleted the feature/partial-blocks branch November 26, 2017 13:28

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Partial blocks and inline partials#9

Partial blocks and inline partials#9
thekid merged 28 commits intomasterfrom
feature/partial-blocks

thekid commented Sep 17, 2017 •

edited

Loading

Uh oh!

thekid Sep 17, 2017

Uh oh!

thekid Sep 17, 2017

Uh oh!

thekid left a comment

Uh oh!

thekid Sep 17, 2017

Uh oh!

thekid Sep 17, 2017

Uh oh!

thekid Sep 17, 2017

Uh oh!

thekid Sep 17, 2017 •

edited

Loading

Uh oh!

thekid Sep 17, 2017

Uh oh!

thekid left a comment

Uh oh!

thekid Sep 17, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

thekid commented Sep 17, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

page.handlebars

layout.handlebars

Uh oh!

thekid Sep 17, 2017

Choose a reason for hiding this comment

Uh oh!

thekid Sep 17, 2017

Choose a reason for hiding this comment

Uh oh!

thekid left a comment

Choose a reason for hiding this comment

Uh oh!

thekid Sep 17, 2017

Choose a reason for hiding this comment

Uh oh!

thekid Sep 17, 2017

Choose a reason for hiding this comment

Uh oh!

thekid Sep 17, 2017

Choose a reason for hiding this comment

Uh oh!

thekid Sep 17, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

thekid Sep 17, 2017

Choose a reason for hiding this comment

Uh oh!

thekid left a comment

Choose a reason for hiding this comment

Uh oh!

thekid Sep 17, 2017

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

thekid commented Sep 17, 2017 •

edited

Loading

thekid Sep 17, 2017 •

edited

Loading