Images - oneCellAnchor #135
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous work in xou#124 by @ngscheurich and @joseustra was using a twoCellAnchor but that's quite tricky to get right. This is now using a oneCellAnchor to make the calculations much simpler. The api is almost the same, but you don't need to add any emu based values for offsets. You can also align the image from the right of a cell. That's something I needed but you also have to take the max character width into account. Also added a few extra tests for a few basic files. I also fixed the formula because it didn't work in the example file.
xou
force-pushed
the
master
branch
3 times, most recently
from
e7bdfd0
to
68acd8d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to @ngscheurich and @joseustra for the previous on trying to
get images working.
#124 by was using twoCellAnchor but that needed more details
which were not very easy to perfect with the variable max
character width for different fonts and font sizes.
This is now using a oneCellAnchor to make the calculations much simpler.
I added an option to align the image from the right of a cell.
That's something I needed but you also have to take the max
character width into account.
I also fixed the formula because it didn't work in the example file.
Edit: Forgot I also added font + font_size options to the workbook