shave some bytes #10
Open
shave some bytes #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HattonLe
reviewed
Oct 19, 2024
| call tok_next | ||
| compile_stmts_tok_next: | ||
| call tok_next | ||
| db 0x81 ; mask following call |
|
Instead of using a 2-bytes jump to compile_stmts, we form a "do-nothing"
instruction using the 0x81 byte that happens to overlap with the call
instruction, and then we can fall through to compile_stmts using only one
byte.
…On Sat, 19 Oct 2024 at 05:30, HattonLe ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In sectorc.s
<#10 (comment)>:
> compile_stmts_tok_next2:
call tok_next
compile_stmts_tok_next:
call tok_next
+ db 0x81 ; mask following call
what does this 0x81 byte do?
—
Reply to this email directly, view it on GitHub
<#10 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABWSFM3XTXMBEM6QVMYPBRDZ4JGFNAVCNFSM6AAAAABQHOGLRGVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDGNZZGQYDQNBZGU>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.