Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed from LGPL'd base64 lib to more permissive one #16

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Changed from LGPL'd base64 lib to more permissive one #16

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Aug 31, 2016

Changed from LGPL'd base64 encode and decode implementations to more permissivly licensed ones, taken from the BaseXX library.

Changed from LGPL'd base64 encode and decode implementations to more permissivly licensed ones, taken from the BaseXX library.
@xopxe
Copy link
Owner

xopxe commented Sep 7, 2016

Good idea... Nevertheless I'll ask the author of the current code for a license change first.
Have you checked other alternatives besides the one you propose? Why did you pick this one? The implementations looks pretty clean, but I see some arrays of bits being instantiated in a loop in there, and wonder about performance...

@lePereT
Copy link

lePereT commented Jun 11, 2021

Hi xopxe - is there a chance that this can get merged? Or is the loop issue you identified still an issue?

@xopxe
Copy link
Owner

xopxe commented Jun 11, 2021

Hi. Sorry I didn't get back on this. I didn't profile, but the implementation you provided does look inneficient, with lots of table.inserts and string.gsubs.
Have you looked at the implementation at https://github.com/iskolbin/lbase64/blob/master/base64.lua ? It's the base64 rock from luarocks, and It's MIT / Public Domain. It also can take advantage of binary operators when available (Lua 5.3+, LuaJIT).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants