Fix SubFileSystem watcher (sometimes) silently discarding events #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Watcher events get silently discarded if all conditions are met: * SubFileSystem was created with incorrect case * Changed file path includes a ~ * Any segment of changed file path is short enough to possibly be a SFN
Fixes TestSubFileSystem.TestWatcherCaseSensitive
xoofx
reviewed
Jun 21, 2024
A bit friendlier for CI runners
|
That's great, thanks for spotting this and making a PR to fix it, appreciated! |
|
@xoofx this is a breaking change, should the package get a major version bump? var fs = new PhysicalFileSystem();
fs.ConvertPathFromInternal(@"/test")In 0.18.0 this results in to |
It is using semver 2.0, so 0.x.y is considered as unstable, so the API has never been stabilized, so technically, any 0.x.y can be a major version bump 🙂 That being said, if you can find a fix to workaround this, PR welcome. @Metapyziks, would adding a check for the specific case of |
|
Sorry for the delay, I'll have a look now. |
Metapyziks
added a commit
to Facepunch/zio
that referenced
this pull request
Jul 25, 2024
Metapyziks
added a commit
to Facepunch/zio
that referenced
this pull request
Jul 25, 2024
Metapyziks
added a commit
to Facepunch/zio
that referenced
this pull request
Jul 30, 2024
Also explain why we're not just always calling Path.GetFullPath xoofx#92
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #91 by only calling Path.GetFullPath for non-rooted paths on Windows in PhysicalFileSystem.ConvertPathFromInternalImpl.
Paths from filesystem events are already rooted, so this skips the weird behaviour for paths containing a
~.