Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correction GetFirstDirectory #72

Merged
merged 6 commits into from
Jan 24, 2023
Merged

Correction GetFirstDirectory #72

merged 6 commits into from
Jan 24, 2023

Conversation

ykafia
Copy link
Contributor

@ykafia ykafia commented Dec 28, 2022

GetFirstDirectory should work with relative paths too and not remove omit the first character

@xoofx
Copy link
Owner

xoofx commented Jan 21, 2023

Thanks! Sorry, completely forgot about this PR.

Could you add some tests please?

@ykafia
Copy link
Contributor Author

ykafia commented Jan 23, 2023

I've added some on a separate file as it's not internal to the UPath behavior, let me know if that's okay

@xoofx
Copy link
Owner

xoofx commented Jan 24, 2023

@ykafia many tests are failing in UPath likely due to the changes

@ykafia
Copy link
Contributor Author

ykafia commented Jan 24, 2023

I will look into it

@ykafia
Copy link
Contributor Author

ykafia commented Jan 24, 2023

All tests are passing now!

@coveralls
Copy link

Coverage Status

Coverage: 90.624% (+0.009%) from 90.614% when pulling 80998d6 on ykafia:ykafia-patch-extension into 930974d on xoofx:main.

@xoofx xoofx merged commit 38c01ea into xoofx:main Jan 24, 2023
@xoofx
Copy link
Owner

xoofx commented Jan 24, 2023

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ykafia @xoofx @coveralls