Fix IFileSystemWatcher instances not being removed from AggregateFSWs #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…SystemWatchers Also dispose watchers before the IFileSystem
|
Thanks! (Glad that you are using it! as I don't have the time for my own project, so it's difficult to evaluate how much the library is reliable on this) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The watchers had
FileSystemset to theMountFileSystemand removal was checking for the internalIFileSystembeing watched. Those are never going to be the same so the instances were never removed.I noticed this when I had a
PhysicalFileSystemmounted, watched theMountFileSystem, then remove (and dispose) the physical FS instance. When the watcher picks something up it'll throw anObjectDisposedExceptiontrying to use thePhysicalFileSysteminstance.I also moved the removal (and disposal) of those FSWs to happen before FS disposal could happen to avoid a similar disposal issue.